Skip to content

Add CSP nonce when handling JS views

Heinrich Lee Yu requested to merge add-nonce-js-views into master

What does this MR do?

This adds the CSP nonce when jQuery evals JS from Rails JS views.

rails-ujs handles this by default but we're using jquery-ujs. I tried switching libraries but it caused too many side-effects.

This would prevent errors when we enable CSP by default in https://gitlab.com/gitlab-org/gitlab-ce/issues/65675

Does this MR meet the acceptance criteria?

Conformity

Performance and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Heinrich Lee Yu

Merge request reports