Skip to content
Snippets Groups Projects

Support adding and removing labels w/ push opts

Merged Christian Couder requested to merge add-label-push-opts into master

What does this MR do?

This MR adds 2 new push options. One to add a label to a MR. The other to remove a label from a MR.

Relates to https://gitlab.com/gitlab-org/gitlab-ce/issues/64320

Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/5942

Does this MR meet the acceptance criteria?

Conformity

Performance and Testing

This should not change performance of the product as there are no loops and only small operations involved. Additional test coverage is in this MR, in a similar way as how other push options are tested.

Edited by Christian Couder

Merge request reports

Pipeline #80162644 passed with warnings

Pipeline passed with warnings for 582e075e on add-label-push-opts

Test coverage 75.35% (-0.00%) from 2 jobs
Approval is optional

Merged by Ash McKenzieAsh McKenzie 5 years ago (Sep 6, 2019 2:58am UTC)

Merge details

Pipeline #80625742 failed

Pipeline failed for 42850018 on master

Test coverage 53.83% (-0.00%) from 2 jobs

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • For any other reviewers, @chriscool kindly documented the changes needed to test out push options locally here

  • added 1 commit

    • 5f7eeba6 - Support adding and removing labels w/ push opts

    Compare with previous version

  • Christian Couder resolved all threads

    resolved all threads

  • assigned to @marcia

  • Ash McKenzie
  • Ash McKenzie
  • Ash McKenzie
  • Ash McKenzie
  • This is an awesome feature addition @chriscool :thumbsup: I've made some suggestions for your consideration :pray: :ping_pong:

  • added 1 commit

    • 90689c30 - Avoid creating labels when removing them

    Compare with previous version

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading