Support adding and removing labels w/ push opts
What does this MR do?
This MR adds 2 new push options. One to add a label to a MR. The other to remove a label from a MR.
Relates to https://gitlab.com/gitlab-org/gitlab-ce/issues/64320
Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/5942
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry for user-facing changes, or community contribution. Check the link for other scenarios. -
Documentation created/updated or follow-up review issue created -
Code review guidelines -
Style guides
Performance and Testing
This should not change performance of the product as there are no loops and only small operations involved. Additional test coverage is in this MR, in a similar way as how other push options are tested.
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process.
Merge request reports
Activity
added customer devopscreate groupsource code repository typefeature labels
1 Warning 582e075e: This commit’s subject line is acceptable, but please try to reduce it to 50 characters. Reviewer roulette
Changes that require review have been detected! A merge request is normally reviewed by both a reviewer and a maintainer in its primary category (e.g. frontend or backend), and by a maintainer in all other categories.
To spread load more evenly across eligible reviewers, Danger has randomly picked a candidate for each review slot. Feel free to override this selection if you think someone else would be better-suited, or the chosen person is unavailable.
Once you've decided who will review this merge request, mention them as you normally would! Danger does not (yet?) automatically notify them for you.
Category Reviewer Maintainer backend David Wilkins ( @dwilkins
)Ash McKenzie ( @ashmckenzie
)Generated by
DangerEdited by 🤖 GitLab Bot 🤖added 1 commit
- dee9d80b - Support adding and emoving labels w/ push opts
changed milestone to %12.3
added 1 commit
- 9aa32122 - Support adding and removing labels w/ push opts
added 1 commit
- a8f73187 - Support adding and removing labels w/ push opts
added 1 commit
- cb7bfd62 - Support adding and removing labels w/ push opts
added 1 commit
- e9a96b6a - Support adding and removing labels w/ push opts
added 1 commit
- b03a7091 - Support adding and removing labels w/ push opts
marked the checklist item Changelog entry for user-facing changes, or community contribution. Check the link for other scenarios. as completed
marked the checklist item Documentation created/updated or follow-up review issue created as completed
added 1 commit
- 4efa8154 - Support adding and removing labels w/ push opts
added 1 commit
- 1d1cf437 - Support adding and removing labels w/ push opts
added 1 commit
- b41e68e3 - Support adding and removing labels w/ push opts
assigned to @dwilkins
added 1 commit
- 53db028d - Support adding and removing labels w/ push opts
added 1 commit
- decfac22 - Support adding and removing labels w/ push opts
added 1 commit
- aa5cc7e0 - Support adding and removing labels w/ push opts
marked the checklist item Style guides as completed
marked the checklist item Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. as completed
- Resolved by Christian Couder
@chriscool Code looks really good. Just one question ...
If I attempt to unlabel a MR with a non-existent label, it creates that label and doesn't label the MR. I'm not sure if it should create the label in that case
Edited by David Wilkins
- Resolved by Christian Couder
unassigned @dwilkins
For any other reviewers, @chriscool kindly documented the changes needed to test out push options locally here
added 1 commit
- 5f7eeba6 - Support adding and removing labels w/ push opts
assigned to @ashmckenzie
added documentation label
- Resolved by Christian Couder
Is there a desire (and Issue) for adding/removing multiple labels?
- Resolved by Christian Couder
assigned to @marcia
- Resolved by Christian Couder
- Resolved by Ash McKenzie
- Resolved by Christian Couder
- Resolved by Christian Couder
- Resolved by Christian Couder
- Resolved by Christian Couder
- Resolved by Christian Couder
- Resolved by Ash McKenzie
- Resolved by Christian Couder
- Resolved by Christian Couder
- Resolved by Ash McKenzie
This is an awesome feature addition @chriscool
I've made some suggestions for your considerationunassigned @ashmckenzie