Enable DAG support by default
What does this MR do?
This makes ci_dag_support
to be enabled by default.
This introduces a small penalty for every pipeline that
does not use DAG
as we execute additional query to find
all dependent jobs that are affected by the current one
that should be transitioned. This with the amount of needs:
limits the performance impact of this feature.
The limit can be made larger (to 50 needs:
) with disable of
ci_dag_limit_needs
, it is still limited, but 50 vs 5.
This change has a potential stability impact. We run all related
DAG changes (with this feature flag being on) on dev.gitlab.org
for last 1.5 wk.
References
- Follow-up after: https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/31803.
- In response to: https://gitlab.com/gitlab-com/gl-infra/infrastructure/issues/7541.
- Check the Slack: https://gitlab.slack.com/archives/CLZPYJZSN/p1565771909018400
- Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/65457
Does this MR meet the acceptance criteria?
Conformity
Merge request reports
Activity
changed milestone to %12.2
added Category:Continuous Integration Stretch devopsverify feature flag grouppipeline execution + 1 deleted label
assigned to @stanhu
@stanhu I'm assigning that to you, as this is high profile and high impact feature.
I'm still continuing to work on https://gitlab.com/gitlab-org/gitlab-ce/issues/65538, and https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/31783 that will make pipeline processing to be significantly cheaper.
Edited by Kamil TrzcińskiFrom a product perspective this plan makes sense to me. Approving from that perspective, but this of course still needs an engineering leadership review of some kind.
Edited by Jason Yavorska2 Warnings Please add a throughput label to this merge request. CHANGELOG missing. You can create one with:
bin/changelog -m 31814 "Enable dag support by default"
If your merge request doesn’t warrant a CHANGELOG entry,
consider adding any of the ~backstage, ci-build, ~Documentation, meta, QA, test labels.
See the documentation.Reviewer roulette
Changes that require review have been detected! A merge request is normally reviewed by both a reviewer and a maintainer in its primary category (e.g. frontend or backend), and by a maintainer in all other categories.
To spread load more evenly across eligible reviewers, Danger has randomly picked a candidate for each review slot. Feel free to override this selection if you think someone else would be better-suited, or the chosen person is unavailable.
Once you've decided who will review this merge request, mention them as you normally would! Danger does not (yet?) automatically notify them for you.
Category Reviewer Maintainer backend Mario de la Ossa ( @mdelaossa
)Mayra Cabrera ( @mayra-cabrera
)Generated by
Danger- Resolved by Kamil Trzciński
Ok, I see the plan in https://gitlab.com/gitlab-com/gl-infra/infrastructure/issues/7541. It sounds like a low limit will mitigate the risk this overwhelms the system, right?
assigned to @rspeicher
unassigned @stanhu
@ayufan LGTM, thanks!
Since it got approved by @stanhu and @rspeicher I merge it. cc @jlenny
Edited by Kamil Trzcińskimentioned in commit 4418907c
added typefeature label