Skip to content

Extract /internal/allowed API Actor logic out

Ash McKenzie requested to merge ashmckenzie/provide_gl-type_to_gitlab_shell into master

What does this MR do?

As part of including what kind of key (Key, DeployKey or LDAPKey) is in use for gitlab-shell (gitlab-shell#203 (closed)), I extracted out some of the more edge logic into a new class called API::Support::Actor which cleans things up, will make it easier to test and paves the way for adding what kind of key might be in use.

Does this MR meet the acceptance criteria?

Conformity

Performance and testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Nick Thomas

Merge request reports