Skip to content

De-duplicate pipeline process sidekiq jobs

Shinya Maeda requested to merge de-duplicate-pipeline-process-sidekiq-jobs into master

What does this MR do?

The PipelineProcessWorker is initiated when a job is finished. This means if there are 100 jobs in the pipeline stage, 100 of PipelineProcessWorker execution happens. This could be waste of compute resource and cause a race condition.

We solve this problem by enqueuing pipeline job ids to the queueing system - BatchPopQueueing. This will effectively deduplicate concurrent pipeline process and defer the process after the current process is done.

close https://gitlab.com/gitlab-org/gitlab-ce/issues/65416

related to https://gitlab.com/gitlab-org/gitlab-ce/issues/65457

Does this MR meet the acceptance criteria?

Conformity

Performance and testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • [-] Label as security and @ mention @gitlab-com/gl-security/appsec
  • [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • [-] Security reports checked/validated by a reviewer from the AppSec team
Edited by Kamil Trzciński

Merge request reports