Skip to content

WIP: Fix rate limiting for job token requests

What does this MR do?

Fixes Admin Area > Settings > Network > User and IP Rate Limits throttles so that runner requests using a valid job token will now be counted in Authenticated API request rate limit and not in Unauthenticated request rate limit.

Needs an EE port. Careful-- some stuff was backported into CE which will necessitate actual work in the EE port.

Does this MR meet the acceptance criteria?

Conformity

Performance and testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Merge request reports