Skip to content

QA spec for Auto DevOps should use 10GB GKE disk

Dylan Griffith requested to merge qa-gke-cluster-10gb into master

What does this MR do?

This was defaulting to 100GB according to https://cloud.google.com/sdk/gcloud/reference/container/clusters/create#--disk-size which is really not ideal since we haven't automated clean up per gitlab-qa#298 (closed)

Also 10GB is the minimum from what I can tell with the CLI (since I tried 8GB and it failed):

gcloud --project gitlab-paas container clusters create --machine-type n1-highmem-2 --zone us-central1-a dgriffith-2019-07-30t15h09m02s --disk-size 8GB --enable-basic-auth
ERROR: (gcloud.container.clusters.create) argument --disk-size: value must be greater than or equal to 10GB; received: 8GB

Does this MR meet the acceptance criteria?

Conformity

Performance and testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by 🤖 GitLab Bot 🤖

Merge request reports