Skip to content

Change qa-* class references to rspec-* in spec/features/contextual_sidebar_spec.rb

Tanya Pazitny requested to merge tp-qtt182-10 into master

What does this MR do?

Recently, master was broken because a qa selector class was removed from an element while an rspec still referenced it. There are a couple dozen more locations where this could happen and these are potential future breakages as Quality shifts from using qa classes to data selectors. We should decouple rspec dependence on qa selectors.

This MR shifts rspec use of:

  • The class qa-link-pipelines to rspec-link-pipelines and adds that class onto the appropriate element.
  • The class qa-toggle-sidebar to rspec-toggle-sidebar and adds that class onto the appropriate element.
  • The data selector project-link to class rspec-project-link and adds that class onto the appropriate element.

Issue aggregating these fixes: https://gitlab.com/gitlab-org/quality/team-tasks/issues/182

Does this MR meet the acceptance criteria?

Conformity

Performance and testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • [-] Label as security and @ mention @gitlab-com/gl-security/appsec
  • [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • [-] Security reports checked/validated by a reviewer from the AppSec team
Edited by Tanya Pazitny

Merge request reports