Skip to content

Ensure default metrics embed is cached

Sarah Yasonik requested to merge fix-embeds-cache into master

What does this MR do?

This MR fixes a bug in the default metrics markdown embed, which kept it from actually being cached. This fixes both the issue and the false-positive in the spec.

Part of of series of MRs to cleanup & add support for embedding specific metrics in markdown!

Prior context: https://gitlab.com/gitlab-org/gitlab-ce/issues/30423 introduced a default embed.

The below MRs are all part of this work:

Does this MR meet the acceptance criteria?

Conformity

Performance and testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Sarah Yasonik

Merge request reports