Add ESLint vue rules to detect vue i18n offences
What does this MR do?
Adds eslint-plugin-vue-i18n to provide i18n linting for .vue files.
- Files with
eslint-disable
directives will have their outstanding lints addressed in https://gitlab.com/gitlab-org/gitlab-ce/issues/63458, at which point theeslint-disable
s can be removed.
New Rules
- Introduces 2 new rules
- no-bare-strings: providing an error on bare strings
<template>
<div>
<h1>This is a translatable string</h1> // Error: Content should be marked for translation
</div>
</template>
- no-bare-attribute-strings: providing an error on bare attributes
<template>
<div>
<h1 title="This is translatable">{{ __('This is a translatable string') }}</h1> // Error: Attribute should be marked for translation
</div>
</template>
- Provides autofixing for simple offences
- Disables the rules for files that will need to be manually fixed
EE Port
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry for user-facing changes, or community contribution. Check the link for other scenarios. -
Documentation created/updated or follow-up review issue created -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Performance and testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Closes #63560 (closed)
Edited by Ezekiel Kigbo