Changed selection classes to harmonize with other settings
What does this MR do?
This MR harmonizes several selections in the settings page to match most other input/selections in GitLab and removes a duplicated % from an externalized string introduced by b315af80. No new CSS classes were introduced, only used existing once.
| before | after |
|---|---|
 |
 |
 |
 |
Since there was no feedback on my issue #62286 (closed) yet, I just went ahead and took a look into the codebase.
Tested on Firefox 68.0.1, Chrome 75.0.3770.142, Safari 12.1.2 (14607.3.9) and Edge 44.17763.1.0.
Didn't test on IE due to the lack of older VMs and desire to use Microsoft's browsers longer than necessary
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry for user-facing changes, or community contribution. Check the link for other scenarios. -
Documentation created/updated or follow-up review issue created -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Performance and testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec -
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Closes #62286 (closed)