Have deterministic DNS for specs
What does this MR do?
-
sham_rack
gem cannot handle IPv6 addresses. This was causingspec/lib/gitlab/http_connection_adapter_spec.rb
to fail with a very hard-to-debugArgumentError: invalid address
-
ArgumentError: invalid address
turns out to be that sham_rack does not support IPv6 address -
FIX: remove gem - one less
Net::HTTP
monkeypatch
-
- Turns out on my machine, Addrinfo resolvs to return an IPv6 address first.
spec/lib/gitlab/http_connection_adapter_spec.rb
seems to assume IPv4 address will be returned first.- FIX: make DNS deterministic with stubs
> addrinfo = Addrinfo.getaddrinfo 'example.org', 80, nil, :STREAM
=> [#<Addrinfo: [2606:2800:220:1:248:1893:25c8:1946]:80 TCP (example.org)>, #<Addrinfo: 93.184.216.34:80 TCP (example.org)>]
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry for user-facing changes, or community contribution. Check the link for other scenarios. -
Documentation created/updated or follow-up review issue created -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Performance and testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Edited by 🤖 GitLab Bot 🤖