Skip to content

Add new table to store email domain per group

Gosia Ksionek requested to merge 10972-be-allow-restricting-group-members-by-a-domain-whitelist-ce into master

What does this MR do?

Connected with https://gitlab.com/gitlab-org/gitlab-ee/issues/10972 and https://gitlab.com/gitlab-org/gitlab-ee/issues/7297

Add a table to store email domain preferences per group.

Database checklist

When adding migrations:

  • Updated db/schema.rb
  • Added a down method so the migration can be reverted
  • Added the output of the migration(s) to the MR body
  • Added tests for the migration in spec/migrations if necessary (e.g. when migrating data)

Migration output:

== 20190723153247 CreateAllowedEmailDomainsForGroups: migrating ===============
-- create_table(:allowed_email_domains)
   -> 0.0330s
== 20190723153247 CreateAllowedEmailDomainsForGroups: migrated (0.0330s) ======

When adding or modifying queries to improve performance:

  • Included data that shows the performance improvement, preferably in the form of a benchmark
  • Included the output of EXPLAIN (ANALYZE, BUFFERS) of the relevant queries

When adding foreign keys to existing tables:

  • Included a migration to remove orphaned rows in the source table before adding the foreign key
  • Removed any instances of dependent: ... that may no longer be necessary

When adding tables:

  • Ordered columns based on the Ordering Table Columns guidelines
  • Added foreign keys to any columns pointing to data in other tables
  • Added indexes for fields that are used in statements such as WHERE, ORDER BY, GROUP BY, and JOINs

When removing columns, tables, indexes or other structures:

  • Removed these in a post-deployment migration
  • Made sure the application no longer uses (or ignores) these structures
Edited by Gosia Ksionek

Merge request reports