Skip to content

Support dashboard params for metrics dashboard endpoint

Sarah Yasonik requested to merge specific-embeds-be into master

What does this MR do?

Part of of series of MRs to cleanup & add support for embedding specific metrics in markdown!

This MR

This particular MR adds support for several params on the EnvironmentsController#metrics_dashboard endpoint - group, title, and y_label. Together with the dashboard param, these params provide enough information to uniquely identify a chart on the metrics dashboard.

Metrics are stored in multiple locations - both the DB and the project's files. This MR adds classes which handle each of these cases uniquely.

Note: This MR has no user-facing changes, so it will not include a changelog.

Context

Prior context: https://gitlab.com/gitlab-org/gitlab-ce/issues/30423 introduced a default embed.

The below MRs are all part of this work:

Does this MR meet the acceptance criteria?

Conformity

Performance and testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Sarah Yasonik

Merge request reports