Skip to content

Fix pid discovery for Unicorn in PidProvider

Aleksei Lipniagov requested to merge 64972-fix-unicorn-workers-metric into master

What does this MR do?

We'll not use ::Prometheus::Client::Support::Unicorn.worker_id in PidProvider, instead we'll parse $0 like we do for Puma.

The reason is ::Prometheus::Client::Support::Unicorn.worker_id provides incorrect value when is called from puma-master (expecting: nil, real: 0 or any worker was found with .first – see the related issue for details)

Does this MR meet the acceptance criteria?

Conformity

Related to #64972 (closed)

Edited by 🤖 GitLab Bot 🤖

Merge request reports