Reorganize metrics dashboard
What does this MR do?
Moves the classes which generate dashboards into their own directory in preparation to add a couple new classes for https://gitlab.com/gitlab-org/gitlab-ce/issues/63199. Probably should happen either way, though, so moving to its own MR seems sensible.
- Moves
BaseService
to/services
- Moves
ProjectDashboardService
to/services
- Moves
SystemDashboardService
to/services
- Renames
DynamicDashboardService
toDefaultEmbedService
and moves it to/services
This has no user-facing changes, but is not technically a ~backstage change, as the changes are ultimately moving toward a ~feature. No changelog will be included and the ~backstage label will not be included to avoid muddling throughput metrics.
Does this MR meet the acceptance criteria?
Conformity
- [n/a] Changelog entry for user-facing changes, or community contribution. Check the link for other scenarios.
- [n/a] Documentation created/updated or follow-up review issue created
-
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Performance and testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. - [n/a] Tested in all supported browsers
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Edited by Sarah Yasonik