Skip to content

Remove blank block from job sidebar

Miranda Fluharty requested to merge 59521-job-sidebar-has-a-blank-block into master

What does this MR do?

Remove the blank block that was displayed in the job sidebar in some cases:

before after
Screen_Shot_2019-07-22_at_13.29.48 Screen_Shot_2019-07-22_at_13.30.31

This block was being rendered depending on the output of the renderBlock() function, but the function was out of sync with what's shown in the block, so there were some cases where the function returned true based on something that is no longer used in the block (job.merge_request, job.cancel_path, etc.)

Does this MR meet the acceptance criteria?

Conformity

Performance and testing

Closes #59521 (closed)

Edited by Miranda Fluharty

Merge request reports