Skip to content

Fix race condition with polling when saving notes

Heinrich Lee Yu requested to merge fix-comment-race-condition into master

What does this MR do?

Fixes flaky spec due to comment being saved before discussions are loaded.

From https://gitlab.com/gitlab-org/gitlab-ee/issues/12472#note_191659334:

we click 'Comment' and trigger handleSave before fetchDiscussions has returned and triggered initPolling in notes_app.

This MR adds a null check to stopPolling and restartPolling when the polling is not initialized yet. These should be fine to ignore since the polling will be properly initialized after the discussions are loaded.

Closes https://gitlab.com/gitlab-org/gitlab-ee/issues/12472

Does this MR meet the acceptance criteria?

Conformity

Performance and testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Heinrich Lee Yu

Merge request reports