Do Redis lookup in batches in ActiveSession.sessions_from_ids
What does this MR do?
By doing smaller mget
calls to Redis, it can better schedule the workload. Currently a single mget
with a lot of keys can keep Redis busy for long, while nothing in its queue gets processed.
https://gitlab.com/gitlab-org/gitlab-ce/issues/64315
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation created/updated or follow-up review issue created -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Performance and testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Edited by Imre Farkas