Skip to content
GitLab
Next
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • GitLab FOSS GitLab FOSS
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 0
    • Issues 0
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
    • Requirements
  • Merge requests 1
    • Merge requests 1
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Container Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Metrics
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • Code review
    • Insights
    • Issue
    • Repository
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Commits
  • Issue Boards
Collapse sidebar
  • GitLab.orgGitLab.org
  • GitLab FOSSGitLab FOSS
  • Merge requests
  • !30485

Allow specifying variables when running manual jobs

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Matija Čupić requested to merge mc/feature/manual-job-variables into master Jul 08, 2019
  • Overview 101
  • Commits 31
  • Pipelines 43
  • Changes 29

What does this MR do?

EE MR https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/14784

  • Backend
    • Write Job variable application code
    • Write Job variables database migration
    • Write Job variable specs
  • Frontend
    • Create component with form
    • Render the manual variables component when playable only
    • Handle secret value change
    • POST request
    • Update the text
    • Add specs
Screenshot_2019-07-17_at_10.29.42 Screenshot_2019-07-17_at_10.30.05
Screenshot_2019-07-17_at_10.30.41 Screenshot_2019-07-17_at_10.31.33

Does this MR meet the acceptance criteria?

Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/24935

Conformity

  • Changelog entry
  • Documentation created/updated or follow-up review issue created
  • Code review guidelines
  • Merge request performance guidelines
  • Style guides
  • Database guides
  • Separation of EE specific content

Performance and testing

  • Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process.
  • Tested in all supported browsers

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • N/A Label as security and @ mention @gitlab-com/gl-security/appsec
  • N/A The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • N/A Security reports checked/validated by a reviewer from the AppSec team
Edited Jul 22, 2019 by Matija Čupić
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: mc/feature/manual-job-variables