Skip to content

GitLab Next

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
GitLab FOSS
GitLab FOSS
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 0
    • Issues 0
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
    • Iterations
  • Merge Requests 0
    • Merge Requests 0
  • Requirements
    • Requirements
    • List
  • Security & Compliance
    • Security & Compliance
    • Dependency List
    • License Compliance
  • Operations
    • Operations
    • Incidents
    • Environments
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • Code Review
    • Insights
    • Issue
    • Repository
    • Value Stream
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Create a new issue
  • Commits
  • Issue Boards
  • GitLab.org
  • GitLab FOSSGitLab FOSS
  • Merge Requests
  • !30485

Merged
Opened Jul 08, 2019 by Matija Čupić@matteeyahDeveloper16 of 18 tasks completed16/18 tasks

Allow specifying variables when running manual jobs

  • Overview 97
  • Commits 31
  • Pipelines 43
  • Changes 29

What does this MR do?

EE MR https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/14784

  • Backend
    • Write Job variable application code
    • Write Job variables database migration
    • Write Job variable specs
  • Frontend
    • Create component with form
    • Render the manual variables component when playable only
    • Handle secret value change
    • POST request
    • Update the text
    • Add specs
Screenshot_2019-07-17_at_10.29.42 Screenshot_2019-07-17_at_10.30.05
Screenshot_2019-07-17_at_10.30.41 Screenshot_2019-07-17_at_10.31.33

Does this MR meet the acceptance criteria?

Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/24935

Conformity

  • Changelog entry
  • Documentation created/updated or follow-up review issue created
  • Code review guidelines
  • Merge request performance guidelines
  • Style guides
  • Database guides
  • Separation of EE specific content

Performance and testing

  • Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process.
  • Tested in all supported browsers

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • N/A Label as security and @ mention @gitlab-com/gl-security/appsec
  • N/A The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • N/A Security reports checked/validated by a reviewer from the AppSec team
Edited Jul 22, 2019 by Matija Čupić
Assignee
Assign to
Reviewer
Request review from
12.2
Milestone
12.2 (Past due)
Assign milestone
Time tracking
Reference: gitlab-org/gitlab-foss!30485
Source branch: mc/feature/manual-job-variables

Revert this merge request

This will create a new commit in order to revert the existing changes.

Switch branch
Cancel
A new branch will be created in your fork and a new merge request will be started.

Cherry-pick this merge request

Switch branch
Cancel
A new branch will be created in your fork and a new merge request will be started.