Skip to content
GitLab
Next
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • GitLab FOSS GitLab FOSS
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 0
    • Issues 0
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
    • Requirements
  • Merge requests 1
    • Merge requests 1
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Container Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Metrics
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • Code review
    • Insights
    • Issue
    • Repository
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Commits
  • Issue Boards
Collapse sidebar
  • GitLab.orgGitLab.org
  • GitLab FOSSGitLab FOSS
  • Merge requests
  • !30444

Remove the feature flag for GraphQL

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged charlie ablett requested to merge 59965-remove-the-feature-flag-for-graphql into master Jul 08, 2019
  • Overview 19
  • Commits 2
  • Pipelines 8
  • Changes 11

What does this MR do?

Remove the :graphql feature flag so GraphQL always acts as "on".

Does this MR meet the acceptance criteria?

Conformity

  • [-] Changelog entry
  • Documentation created/updated or follow-up review issue created
  • [-] Code review guidelines
  • [-] Merge request performance guidelines
  • Style guides
  • [-] Database guides
  • [-] Separation of EE specific content

Performance and testing

  • Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process.
  • Tested in all supported browsers

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • [-] Label as security and @ mention @gitlab-com/gl-security/appsec
  • [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • [-] Security reports checked/validated by a reviewer from the AppSec team

Closes #59965 (closed)

Edited Jul 09, 2019 by charlie ablett
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: 59965-remove-the-feature-flag-for-graphql