Skip to content

Extract Auto DevOps deploy functions in a base image

Thong Kuah requested to merge extract_auto_deploy_into_base_image into master

What does this MR do?

Uses image generated from https://gitlab.com/gitlab-org/cluster-integration/auto-deploy-image.

Last part of https://gitlab.com/gitlab-org/gitlab-ce/issues/55165. Closes #50286 (closed)

The functions have been extracted out from this yml to https://gitlab.com/gitlab-org/cluster-integration/auto-deploy-image/blob/v0.1.0/src/bin/auto-deploy

Changes :

  • Image uses bash now (previously it was alpine sh)
  • Rather than installing dependencies everytime, dependencies now comes with the image

TODOs

Does this MR meet the acceptance criteria?

Conformity

Performance and testing

Manual QA

Using the following YAML to test

include:
  - remote: 'https://gitlab.com/gitlab-org/gitlab-ce/raw/extract_auto_deploy_into_base_image/lib/gitlab/ci/templates/Jobs/Deploy.gitlab-ci.yml'

https://staging.gitlab.com/hello-staging/minimal-ruby-app/-/jobs/36078082:

  • review job
  • performance job (which relies on the environment_url.txt)

https://staging.gitlab.com/hello-staging/minimal-ruby-app/-/jobs/36078500

  • production

https://staging.gitlab.com/hello-staging/minimal-ruby-app/-/jobs/36078608

  • staging

https://staging.gitlab.com/hello-staging/minimal-ruby-app/-/jobs/36078612

  • incremental rollout jobs

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by 🤖 GitLab Bot 🤖

Merge request reports