Skip to content

Fix `simple_format` undefined error #60179

What does this MR do?

It fixes #60179 (closed)

I took a look on Rails source code and I found that simple_format is not defined in ActionView::Helpers::TagHelper, however it is actually located in ActionView::Helpers::TextHelper. Also TagHelper is a part of TextHelper (see here)

The solution is to include TextHelper instead of TagHelper. That should be enough to resolve the described problem.

I've added tests to cover the code where simple_format is called.

It's my first MR to GitLab, please let me know if something is missing or requires a change.

Thanks!

Does this MR meet the acceptance criteria?

Conformity

Performance and testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Toon Claes

Merge request reports