Skip to content

Memoizing root_ancestor in Namespace

Adam Hegyi requested to merge memoize-namespace-root-ancestor into master

What does this MR do?

The root_ancestor method is heavily used in EE for the group_saml feature. Having this memoization implemented in CE would eliminate the need of overriding the root_ancestor method in EE.

Related Issue: https://gitlab.com/gitlab-org/gitlab-ee/issues/12189

Related MR in EE: https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/14364

Does this MR meet the acceptance criteria?

Conformity

Performance and testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Adam Hegyi

Merge request reports