Skip to content

Don't show image diff note on text file

Patrick Bajao requested to merge 58808-fix-image-diff-on-text into master

What does this MR do?

Fixes Gitlab::Diff::LinesUnfolder#unfold_required? as it was trying to determine if the diff lines around the position of the diff note should be unfolded. It can't do that if the diff note is positioned on an image.

Does this MR meet the acceptance criteria?

Conformity

Performance and testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • [-] Label as security and @ mention @gitlab-com/gl-security/appsec
  • [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • [-] Security reports checked/validated by a reviewer from the AppSec team

#58808 (closed)

Edited by Patrick Bajao

Merge request reports