Refactored settings 'show' panel to 'general'
What does this MR do?
This is a refactoring of https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/25434. This keeps the routes consistent - now the General panel has it's own route. Panel is called "General" in the menu, but it's breadcrumb said "Settings". Renamed to "General" to be consistent with the other panel names. Refactored a spec into a shared example for use in EE.
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation created/updated or follow-up review issue created -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Performance and testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec -
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team