Skip to content

No security scan for docs branches

Philippe Lafoucrière requested to merge no-security-scan-for-docs-branches into master

What does this MR do?

As @axil pointed out in https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/29780#note_185248917, the recent change in the security checks job has the side effect to run them on "docs" branches. This MR not only fixes this and restore the original behavior but also clean-up our definitions to avoid the same mistake in the future. It also leverages the support of multiple extends.

This MR is the continuity of https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/30081 which had a wrong branch name (and we can't change the branch in an MR).

Does this MR meet the acceptance criteria?

Conformity

Performance and testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • [-] Label as security and @ mention @gitlab-com/gl-security/appsec
  • [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • [-] Security reports checked/validated by a reviewer from the AppSec team

Merge request reports

Loading