WIP: Change when to do spam detection
What does this MR do?
This MR changes when a POST/PUT request to both snippets and issues for a project is done. Currently if the project is public, it will check for spam even if it is the owner making the request, and the only way of getting the API call to succeed is to set the visibility to private.
More here - https://gitlab.com/gitlab-org/gitlab-ce/issues/63786
Does this MR meet the acceptance criteria?
It should, but I would love some help either getting gdk to work (spent the day trying, no luck), and writing some basic tests for this functionality.
Conformity
-
Changelog entry -
Documentation created/updated or follow-up review issue created -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Performance and testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec -
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team