Skip to content

WIP: Clean up roulette testing

Alex Kalderimis requested to merge refactor-roulette-testing into master

What does this MR do?

This is a refactor of the roulette.json handling code that runs as a Danger plugin. It extracts I/O calls to an external module so that they are easily testable.

Does this MR meet the acceptance criteria?

Conformity

Performance and testing

This could cause disruption to the reviewer roulette system, used during code review. This is a non-essential system, and the whole point of this MR is to mitigate any risk by improving tests and testability.

Security

This MR does not contain security relevant code.

Edited by Alex Kalderimis

Merge request reports