Skip to content
GitLab Next
  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • GitLab FOSS GitLab FOSS
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 0
    • Issues 0
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
    • Requirements
  • Merge requests 0
    • Merge requests 0
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Package Registry
    • Container Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Metrics
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • Code review
    • Insights
    • Issue
    • Repository
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Commits
  • Issue Boards
Collapse sidebar
  • GitLab.org
  • GitLab FOSSGitLab FOSS
  • Merge requests
  • !29885

Gitlab::JsonCache#parse_value ensure string

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Ash McKenzie requested to merge 63510-error-parsing-true-boolean-in-gitlab-jsoncache into master Jun 20, 2019
  • Overview 8
  • Commits 1
  • Pipelines 1
  • Changes 2

What does this MR do?

This MR ensures raw in Gitlab::JsonCache#parse_value is always dealing with a string before attempting to call ActiveSupport::JSON.decode

Does this MR meet the acceptance criteria?

Conformity

  • Changelog entry
  • [ ] Documentation created/updated or follow-up review issue created
  • Code review guidelines
  • Merge request performance guidelines
  • Style guides
  • [ ] Database guides
  • [ ] Separation of EE specific content

Performance and testing

  • Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process.
  • Tested in all supported browsers

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Closes #63510 (closed)

Edited Jun 20, 2019 by Ash McKenzie
Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: 63510-error-parsing-true-boolean-in-gitlab-jsoncache