Skip to content

Do not rewrite relative links for system notes

Mario de la Ossa requested to merge bug/63162-duplicate_path_in_links into master

What does this MR do?

Fixes https://gitlab.com/gitlab-org/gitlab-ce/issues/63162 by adding a system_note key to the banzai render context for notes, which then disables processing href attributes in RelativeLinkFilter

Does this MR meet the acceptance criteria?

Conformity

Performance and testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Mario de la Ossa

Merge request reports

Loading