Skip to content

Fix cleanup of prometheus files on server start

Jan Provaznik requested to merge puma-init-restart into master

What does this MR do?

It fixes deletion of prometheus files when server starts. on_master_start lifecycle callback is used to assure this. In cluster environment this event maps to before_fork callback.

But there is a difference between Puma and Unicorn:

  • Puma calls before_fork once when booting up master process
  • Unicorn runs before_fork whenever new worker is spawned

To unify this behavior we call before_fork only once - we use this callback for deleting Prometheus files and in config/initializers/macos.rb. So calling it once matches our needs and also requires minimum change in the code.

TODO

Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/62862

Does this MR meet the acceptance criteria?

Conformity

Performance and testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by 🤖 GitLab Bot 🤖

Merge request reports