Skip to content

Fix reports jobs timing out because of cache

Philippe Lafoucrière requested to merge fix-cache-issue-in-secure-job into master

What does this MR do?

Fix reports jobs timing out because of cache.

Note: This commit relies on https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/26801 which brings support to multiple extends.

While cache: {} can disable a cache being set globally, it doesn't work with extends, which will perform a reverse deep merge based on the keys.

The cache defined in the base .default-cache job won't be disabled in the report jobs.

As a side effect, the code_quality, sast, and dependency_scanning jobs are running on a larger code base than expected, leading to timeouts. With this MR, we will see a performance boost for these jobs (only on GitLab-CE/EE pipeline, it's a configuration bug).

fixes https://gitlab.com/gitlab-org/gitlab-ee/issues/11303, https://gitlab.com/gitlab-org/gitlab-ce/issues/60879, https://gitlab.com/gitlab-org/gitlab-ee/issues/12021, https://gitlab.com/gitlab-org/gitlab-ee/issues/12021

Does this MR meet the acceptance criteria?

Conformity

Performance and testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

/cc @stanhu (because he was included in a questions thread and kindly answered, as usual 👍) @theoretick

Credits go to @theoretick for spotting an abnormal behavior during a test 👍 👍

@gonzoyumo @theoretick could you please take a look?

Edited by 🤖 GitLab Bot 🤖

Merge request reports