return boolean from Pipeline::Expression::Lexeme::Matches#evaluate
What does this MR do?
This update changes the behavior of Ci::Pipeline::Expression::Lexeme::Matches#evaluate
to return a boolean true
or false
value. We updated it to return the index of match position in the String, but this caused a regression and is not a critical part of the feature we're delivering in !27925 (merged). There is an open merge request regarding this behavior #29575 (closed) that can be worked on and merged as we make it a priority.
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation created/updated or follow-up review issue created -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Performance and testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Edited by Kamil Trzciński