Skip to content

rack_attack: Exempt jwt/auth requests for gitlab-ci-token

Ben Gamari requested to merge bgamari/gitlab-ce:T49392 into master

What does this MR do?

As described in #49392 (closed), Docker submits requests against /jwt/auth during normal operation which fail. These are currently counted against the per-IP rate limit, usually resulting in a ban. This renders Docker builds from Pipelines extremely unreliable.

This patch excludes requests against /jwt/auth for the gitlab-ci-token account from the rack-attack rate limit.

Does this MR meet the acceptance criteria?

Conformity

Performance and testing

This implements the suggestion proposed in #49392 (closed). No adverse effects are expected.

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Merge request reports