Skip to content

fix(favicon): get favicon_path, so it works also with uploads object store

What does this MR do?

If object store for uploads is enabled, an uploaded favicon is served via object store URL, also with proxy_download: true.

The investigation started here https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/28284

/cc @pslaughter

Does this MR meet the acceptance criteria?

Conformity

Performance and testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • ~~[ ] Label as security and @ mention @gitlab-com/gl-security/appsec~~
  • [ ] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • [ ] Security reports checked/validated by a reviewer from the AppSec team
Edited by Roger Meier

Merge request reports