Skip to content

Fix incorrect reaction placement in commit diff discussion

What does this MR do?

Fix the incorrect placement of reaction/emoji in the commit diff discussion. This is due to the incorrect selection of the corresponding reaction block (awards block). So the fix is selecting the correction element and hence the correct .current class would be placed for the reaction (emoji) to be placed.

Issue

Solution

solution-screen-capture

Manual Test

  1. Navigate to Repository > Commits > [Select a commit]
  2. Add a comment on the code
  3. Reply to that comment
  4. On the response comment (2nd comment), add a reaction emoji
    • The reaction emoji appears on the response comment and NOT the first comment

Tested on:

  • IE11
  • Edge
  • Safari
  • Firefox
  • Chrome

Does this MR meet the acceptance criteria?

Conformity

Performance and testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Closes #54595 (closed)

Edited by Samantha Ming

Merge request reports