Skip to content

Updates on success of an MR the count on top and in other tabs

Tim Zallmann requested to merge tz-update-mr-count-over-tabs into master

What does this MR do?

This will update the open MR count in the top Navigation as soon as you merge or close an MR and it updates also all other open tabs (nice for tab junkies like me) without doing polling.

  • When a MR is merged it requests from a new API the updated MR Count
  • New API endpoint for MR count
  • Updates other tabs by sending a BroadcastMessage
  • When a MR is closed it requests updated MR
  • When a MR is unassigned or assigned
  • API specs
  • JS specs

Kapture_2019-06-10_at_20.42.04

Does this MR meet the acceptance criteria?

Conformity

Performance and testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Tim Zallmann

Merge request reports