Skip to content

Fix GPG signature verification with recent versions of GnuPG

David Palubin requested to merge dpalubin/gitlab-ce:issue-58747 into master

What does this MR do?

This merge request fixes the GPG signature verification for commits for recent versions of GnuPG. Currently the most recent versions (2.2.13 and higher tested) have signed commits show up as unverified despite having a correctly registered GPG key. The problem arises because:

GPGME::Crypto.new.verify(signature_text, signed_text: signed_text)

returns a 16 digit fingerprint in older versions of GPG, but a 40 digit fingerprint in newer ones.

Closes #58747 (closed)

Does this MR meet the acceptance criteria?

Conformity

Performance and testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by David Palubin

Merge request reports