Skip to content

Upgrade capybara to version 3.22.0

Dan Davison requested to merge update-capybara into master

What does this MR do?

Attempt at a fix for https://gitlab.com/gitlab-org/gitlab-ce/issues/58882 .

Update Capybara, also disable automatic saving of screenshots. It's possible that the session is being destroyed before this gem has the ability to take the screenshot.

We can still save screenshots, but we need to hook into the runner on failure.

See https://github.com/mattheworiordan/capybara-screenshot#manual-screenshots

it's entirely possible that all of this is coming from the capybara-screenshot gem. i'm not sure it's maintained any longer. it's possible that Capybara is killing the session "before" the screenshot gem can take on. which would explain the "invalid session id"

because of this, we could at least try an update of capybara. if we see more issues, let's just see if we can isolate it to the autosave_on_failure

why this would be popping up "now", might even be rooted in our automatic updating of the selenium-webdriver gem. the release of selenium-webdriver 3.142.2 which we were currently using back in May, was released May 11th. we started seeing our issues around May 12th

Does this MR meet the acceptance criteria?

Conformity

Edited by Dan Davison

Merge request reports