Ensure DB is writable before continuing jobs
What does this MR do?
In the context of a Geo enabled GitLab instance, the Geo secondary nodes have a read-only PostgreSQL database. This MR adds the return if Gitlab::Database.read_only?
guard before executing further logic to prevent unwanted log spam.
EE version - https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/13943
Issue: https://gitlab.com/gitlab-org/gitlab-ee/issues/11925
Does this MR meet the acceptance criteria?
Conformity
[ ] Changelog entry[ ] Documentation created/updated or follow-up review issue created-
Code review guidelines -
Merge request performance guidelines -
Style guides [ ] Database guides-
Separation of EE specific content
Performance and testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Edited by Ash McKenzie