Skip to content

Create BaseService for Auto Merge architecture

What does this MR do?

This is a follow-up for https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/28595.

We refactored the Auto Merge architecture, however, still shared processes remain in MergeWhenPipelineSucceedsService.

This MR is cleaning it up, and eventually, reduces the change size in https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/13278.

Does this MR meet the acceptance criteria?

Conformity

Performance and testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • [-] Label as security and @ mention @gitlab-com/gl-security/appsec
  • [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • [-] Security reports checked/validated by a reviewer from the AppSec team
Edited by Shinya Maeda

Merge request reports