Skip to content

CE backport for gitlab-ee!13389 (Support storing design blobs using LFS)

Luke Duncalfe requested to merge 9490-store-designs-in-lfs-ce into master

What does this MR do?

This backports to ce a refactor of the shared example 'a controller that can serve LFS files'.

The ee MR that contains the original refactor is https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/13389

The reason for the refactor the removal of the outer context as it prevented let(:lfs_oid) from being overwritten and also was not needed.

The shared example was also renamed to be more descriptive.

Does this MR meet the acceptance criteria?

Conformity

Performance and testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • [-] Label as security and @ mention @gitlab-com/gl-security/appsec
  • [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • [-] Security reports checked/validated by a reviewer from the AppSec team
Edited by Luke Duncalfe

Merge request reports

Loading