Skip to content

Award emojis to comments

Douwe Maan requested to merge comment-award-emoji into master

Fixes https://gitlab.com/gitlab-org/gitlab-ce/issues/3655

  • Refactor issue/MR awards to not use notes, but EmojiAward and Awardable instead.
  • Add Awardable on note.
  • Actually show award widget on each note (requires refactoring of JS, cc @jschatz1)
    • Only render emoji picker once, show the same one where necessary
    • Use container.find(".whatever") instead of $(".whatever"), where container will be each individual award bar
  • Include award users in participants, so they get notifications from the issue
  • Ensure adding an emoji award marks the issue todo as Done
  • Expose emoji awards in API
    • Add endpoints to directly post etc (Mount the same endpoints in Grape)
  • Update tests
  • Write new tests
  • Consistently name these "things" award emoji. "emoji" is a plural noun, "award" is an adjective. They're emoji. What kind of emoji? Award emoji. For some reason I think of them as emoji awards: They're awards. What kind of awards? Emoji awards. But @JobV is very adamant the first is correct.
  • Move award emoji when the issue/MR is moved to another project
  • Support snippets too

Current state: issue/MR awards work as before, but using different logic. Note awards work in theory but are not in the UI, so not in practice.

Merge request reports