Skip to content

Remove fixed height from MR diff headers

Annabel Dunstone Gray requested to merge remove-mr-diff-header-height into master

What does this MR do?

  • This MR removes the fixed 56px height on MR diff and commit file titles

Context

  • The MR diff file header & commit file headers are 56px tall, while snippets and repo file headers are only 42px. Is there a reason for the fixed 56px height? It seems overly tall.

  • I realize 42px isn't a part of our grid, but I propose we tackle that separately as changing the height will have effects on the vertical alignment/spacing of the text and buttons within those file headers.

Before After
Screen_Shot_2019-05-30_at_1.34.05_PM Screen_Shot_2019-05-31_at_10.48.38_AM

Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/62596

Edited by Annabel Dunstone Gray

Merge request reports