Resolve EE/CE differences in app/views/profiles/keys
What does this MR do?
Provides a CE/EE-unified templates for app/views/profiles/keys/_key.html.haml
and app/views/profiles/keys/_key_details.html.haml
The MR also introduces an new method on app/models/key.rb
that gets overridden on EE's side for LDAP keys
When EE counter-part gets merged with it's own additions,
- https://gitlab.com/gitlab-org/gitlab-ee/issues/10506, and
- https://gitlab.com/gitlab-org/gitlab-ee/issues/6227
can be closed
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation created/updated or follow-up review issue created -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Performance and testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Edited by Denys Mishunov