Skip to content

Add karma spec quarantine

Luke Bennett requested to merge karma-quarantine into master

What does this MR do?

  • Upgrades karma-jasmine to 2.0.1 for full regexp support
  • Adds QUARANTINE| to existing quarantine candidates
  • Doesnt run quarantined specs in karma and allows them to fail in karma-quarantine

Quarantined specs only

Screenshot_2019-05-29_at_01.22.26

Unquaratined specs only (default)

Screenshot_2019-05-29_at_01.23.50

Includes a fix from https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/28846.

Does this MR meet the acceptance criteria?

Conformity

Performance and testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Luke Bennett

Merge request reports