Skip to content

Increase GraphQL complexity for fields that make Gitaly Calls

What does this MR do?

The GraphQL query complexity of a field should be increased if resolving that field makes at least one Gitaly call.

Also added is a Sentry error if the field needs to have calls_gitaly declared, but is missing. The logic is not smart enough to know if it's conditional, just that at least one scenario it's true.

EE MR: https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/14529

Does this MR meet the acceptance criteria?

Conformity

Performance and testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • [-] Label as security and @ mention @gitlab-com/gl-security/appsec
  • [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • [-] Security reports checked/validated by a reviewer from the AppSec team

Closes #58409 (closed)

Edited by charlie ablett

Merge request reports