Skip to content

Only show available services

James Fargher requested to merge show_available_services_only into master

What does this MR do?

In https://gitlab.com/gitlab-org/gitlab-ce/issues/39217 we want to remove the Kubernetes integration but not risk actually deleting customer access data. Instead we filter for available services only.

I wanted to do https://gitlab.com/gitlab-org/gitlab-ce/issues/42430 while I'm in the area but this N+1 query is harder to fix than it appears (the error comes from the first time the admin visits the admin page). The controller and views need to be reworked to not try create all services on first visit.

Does this MR meet the acceptance criteria?

Conformity

Performance and testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by 🤖 GitLab Bot 🤖

Merge request reports