Skip to content

Be explicit about setting :masked

Thong Kuah requested to merge explicit_masked_qa into master

What does this MR do?

Currently API defaults :masked to false and browser defaults :masked to true - resolve this ambiguity by requiring QA to be explicit about which value it requires for :masked.

See https://gitlab.com/gitlab-org/quality/nightly/issues/81

QA

set masked to false via API

Screen_Shot_2019-05-27_at_10.40.50_AM

set masked to false via browser UI

Screen_Shot_2019-05-27_at_11.31.32_AM

set masked to true via browser UI

Screen_Shot_2019-05-27_at_11.52.14_AM

Does this MR meet the acceptance criteria?

Conformity

Performance and testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by 🤖 GitLab Bot 🤖

Merge request reports